Render specific blockquotes as Bootstrap panels #182
Conversation
Blockquotes that have a header (with class "callout", "challenge", "prereq", "objectives") as their first element will get rendered as <div>s. Their structure will resemble Bootstrap's panel: http://getbootstrap.com/components/#panels-alternatives There's currently an issue with pandoc: the header nested under the blockquote will never have assigned attributes. This is causing the panel's heading to look enormous. I'll fix it in carpentries/styles#11. BTW: glyphicons won't render correctly unless 'fonts' directory gets moved up one level to the 'css' directory. I'll fix that in carpentries/styles#11 too.
| @@ -1,6 +1,7 @@ | |||
| <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <link rel="stylesheet" type="text/css" href="css/bootstrap/bootstrap.css" /> | |||
| <link rel="stylesheet" type="text/css" href="css/bootstrap/bootstrap-theme.css" /> | |||
There was a problem hiding this comment.
@fmichonneau please take a look at my previews (#182 (comment)) and decide whichever looks nicer: with Bootstrap theme or without.
There was a problem hiding this comment.
OK, I see. bootstrap-theme looks better. We'll need to add it to the style repo though.
There was a problem hiding this comment.
It'll land in carpentries/styles#11
This is already fixed in my branch that will be merged soon into style. We can't change the location of the fonts directory (we need everything in a single directory). Instead, I updated the path in the CSS file. |
Alright, I'll rewrite history (again) in carpentries/styles#11 to get rid of my commit which moves the font directory around. |
|
Thanks for your work @pbanaszkiewicz ! |
|
@fmichonneau thank you for reviewing! :-) |
|
Saw this come up on my radar, and noticed it's been open a while. @pbanaszkiewicz , @fmichonneau - before I review this, are there any remaining known issues that would block a merge? |
|
@abought well this PR is closely related to the carpentries/styles#11 - and we have some issues merging it. @r-gaia-cs what are your thoughts on these two PRs? |
|
@pbanaszkiewicz Can we wait until the begin of next week? My modem stop working last weekend. =( |
|
@r-gaia-cs sure, no hurry! |
There's a note in swcarpentry/DEPRECATED-lesson-template#182 explaining why we need to fix style for panel heading.
|
I'm closing this in favor of #203. |
Blockquotes that have a header (with class "callout", "challenge",
"prereq", "objectives") as their first element will get rendered as
<div>s. Their structure will resemble Bootstrap's panel:http://getbootstrap.com/components/#panels-alternatives
There's currently an issue with pandoc: the header nested under the
blockquote will never have assigned attributes. This is causing the
panel's heading to look enormous. I'll fix it in
carpentries/styles#11.
Previews:
BTW: glyphicons won't render correctly unless 'fonts' directory gets
moved up one level to the 'css' directory. I'll fix that in
carpentries/styles#11 too.