-
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This goes with jpallen/site#c40071f, and is a proof of concept that lesson can share the same CSS as site. I haven't looked at merging slideshow.css yet though. This commit brings the CSS here up to date with the at site (if c40071f is merged) although doesn't address how we'll keep these in sync in future.
The PR to get these CSS changes into site are in swcarpentry/DEPRECATED-site#751 |
@jpallen Thanks for this pull request. Could you split this pull request in two? One with
that needs to be merge into
that needs to be merged into |
Yes, I can split it up. Note that changing either the CSS or HTML without changing the other will leaving the styling broken. Is it ok to have each PR be a breaking change, so long as they work together? |
I think so - I'm guessing Raniere wants it to be easier to cherry-pick |
As per swcarpentry#140, but only the core CSS changes.
As per swcarpentry#140, but with only the HTML changes
@r-gaia-cs I've created the separate pull requests now. |
@r-gaia-cs if this looks good to you, please merge. (We'll worry about copying the CSS into 'core' later.) |
As per #140, but only the core CSS changes.
As per swcarpentry/DEPRECATED-lesson-template#140, but only the core CSS changes.
This goes with jpallen/site#c40071f, and is a proof of concept that lesson can
share the same CSS as site. I haven't looked at merging slideshow.css yet
though. This commit brings the CSS here up to date with the at site (if
c40071f is merged) although doesn't address how we'll keep these in sync in
future.