Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Improve DCE #9853

Merged
merged 12 commits into from
Jan 8, 2025
Merged

fix(es/minifier): Improve DCE #9853

merged 12 commits into from
Jan 8, 2025
+114 −6

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 8, 2025 •
edited
Loading

Description:

  • We should check for the super class while dropping class declarations.
  • Add early-check for null && foo and true || foo.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jan 8, 2025
@kdy1 kdy1 self-assigned this Jan 8, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1464b3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title feat(es/minifier): Expand DCE for class/fn declarations fix(es/minifier): Fix DCE of class declarations Jan 8, 2025
@kdy1 kdy1 marked this pull request as ready for review January 8, 2025 09:22
@kdy1 kdy1 requested a review from a team as a code owner January 8, 2025 09:22
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 8, 2025
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 8, 2025 09:23
@kdy1 kdy1 disabled auto-merge January 8, 2025 09:31
@kdy1 kdy1 changed the title fix(es/minifier): Fix DCE of class declarations fix(es/minifier): Improve DCE Jan 8, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 8, 2025
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) January 8, 2025 09:39
@kdy1 kdy1 requested a review from a team as a code owner January 8, 2025 09:51
@kdy1 kdy1 merged commit 85fb16c into swc-project:main Jan 8, 2025
154 checks passed
@kdy1 kdy1 deleted the issue-9823 branch January 8, 2025 10:21
@kdy1 kdy1 modified the milestones: Planned, v1.10.7 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.10.7
Development

Successfully merging this pull request may close these issues.

Minify failed when meet some webpack comment
1 participant
@kdy1