Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/codegen): Use scoped allocator #9248

Merged
merged 15 commits into from
Jul 15, 2024
Merged

perf(es/codegen): Use scoped allocator #9248

merged 15 commits into from
Jul 15, 2024
+34 −14

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 15, 2024

Description:

Main:
스크린샷 2024-07-15 오후 8 05 50

new:

스크린샷 2024-07-15 오후 8 05 19

@kdy1 kdy1 added this to the Planned milestone Jul 15, 2024
@kdy1 kdy1 self-assigned this Jul 15, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9248 will improve performances by ×2.9

Comparing kdy1:easy (bc4c83b) with main (6e098ae)

Summary

⚡ 2 improvements
✅ 176 untouched benchmarks

Benchmarks breakdown

Benchmark main kdy1:easy Change
⚡ es/codegen/colors 168.6 µs 85 µs +98.4%
⚡ es/codegen/large 2,311.2 µs 807.8 µs ×2.9

@kdy1
Copy link
Member Author

kdy1 commented Jul 15, 2024

Closing in favor of #9245

@kdy1 kdy1 closed this Jul 15, 2024
@kdy1 kdy1 deleted the easy branch July 15, 2024 20:12
@kdy1 kdy1 restored the easy branch July 15, 2024 23:02
@kdy1 kdy1 reopened this Jul 15, 2024
@kdy1 kdy1 changed the base branch from main to alloc July 15, 2024 23:03
@kdy1 kdy1 marked this pull request as ready for review July 15, 2024 23:04
@kdy1 kdy1 requested review from a team as code owners July 15, 2024 23:04
@kdy1 kdy1 merged commit 58ff128 into swc-project:alloc Jul 15, 2024
301 of 302 checks passed
@kdy1 kdy1 deleted the easy branch July 15, 2024 23:21
@kdy1 kdy1 mentioned this pull request Jul 15, 2024
Merged
kdy1 added a commit that referenced this pull request Jul 16, 2024
@kdy1
perf(es/codegen): Use scoped allocator (#9248)
970f323 
**Description:**

Main:
<img width="711" alt="스크린샷 2024-07-15 오후 8 05 50"
src="https://github.com/user-attachments/assets/508a29e8-744f-4017-a819-b7576e61d287">

new:

<img width="711" alt="스크린샷 2024-07-15 오후 8 05 19"
src="https://github.com/user-attachments/assets/bcf3107d-e843-4fab-8b8a-fc6376705273">
kdy1
kdy1 commented Jul 16, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen --breaking

kdy1 added a commit to kdy1/swc that referenced this pull request Jul 17, 2024
@kdy1
Revert "perf(es/codegen): Use scoped allocator (swc-project#9248)"
c5edddb 
This reverts commit 970f323.
kdy1 added a commit that referenced this pull request Jul 17, 2024
@kdy1
refactor(es/codegen): Revert #9248 (#9266)
b9b233c
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
kdy1 added a commit to kdy1/swc that referenced this pull request Jul 17, 2024
@kdy1
Revert "refactor(es/codegen): Revert swc-project#9248 (swc-project#9266…
299b75b 
…)"

This reverts commit b9b233c.
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1