Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Check this in function params #9229

Merged
merged 4 commits into from
Jul 13, 2024
Merged

fix(es/minifier): Check this in function params #9229

merged 4 commits into from
Jul 13, 2024
+59 −1

Conversation

CPunisher
Copy link
Contributor

Related issue (if exists):

Closes #9186

@CPunisher CPunisher requested a review from a team as a code owner July 13, 2024 03:30
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 13, 2024

CodSpeed Performance Report

Merging #9229 will not alter performance

Comparing CPunisher:fix/func-to-arrow (b7636a9) with main (aa7f791)

Summary

✅ 173 untouched benchmarks

@kdy1 kdy1 added this to the Planned milestone Jul 13, 2024
@kdy1 kdy1 self-assigned this Jul 13, 2024
kdy1
kdy1 reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) July 13, 2024 05:41
@kdy1 kdy1 disabled auto-merge July 13, 2024 05:52
@kdy1 kdy1 merged commit da4866d into swc-project:main Jul 13, 2024
152 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Incorrect transformation to arrow function when using this for a default parameter value
2 participants
@CPunisher @kdy1