-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(allocator): Initialize package #9195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_allocator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably reference our code :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I depended on oxc_allocator
but the problem was the lack of trait implementations of Box
.
I prefer depending on oxc_allocator,
but I created a new package instead of requesting implementing them mainly because of rkyv
. Traits like PartialEq
may be also useful for oxc
, but AFAIK, oxc
has nothing to do with rkyv
. If you are fine with adding some derives for rkyv
, I'll use oxc_alllocator
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to have your own abstraction. I was saying you should put a comment saying where the code originated from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I added it with be99ce0
Description:
BREAKING CHANGE:
Related issue (if exists):