Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(allocator): Initialize package #9195

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat(allocator): Initialize package #9195

merged 1 commit into from
Jul 10, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 10, 2024

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jul 10, 2024
@kdy1 kdy1 self-assigned this Jul 10, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 10, 2024 09:45
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_allocator

@kdy1 kdy1 enabled auto-merge (squash) July 10, 2024 09:47
@kdy1 kdy1 disabled auto-merge July 10, 2024 09:47
@kdy1 kdy1 merged commit f3681cb into swc-project:main Jul 10, 2024
148 of 150 checks passed
@kdy1 kdy1 deleted the swc-alloc branch July 10, 2024 09:47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably reference our code :-(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I depended on oxc_allocator but the problem was the lack of trait implementations of Box.
I prefer depending on oxc_allocator, but I created a new package instead of requesting implementing them mainly because of rkyv. Traits like PartialEq may be also useful for oxc, but AFAIK, oxc has nothing to do with rkyv. If you are fine with adding some derives for rkyv, I'll use oxc_alllocator instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to have your own abstraction. I was saying you should put a comment saying where the code originated from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I added it with be99ce0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants