Skip to content

fix(es/testing): Make test_inline! not read output as a file #8569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix(es/testing): Make test_inline! not read output as a file #8569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6bdd5f
fix
kdy1 Jan 29, 2024
78d15bf
fix
kdy1 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions crates/swc_ecma_transforms_testing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,10 @@ where
{
let _logger = testing::init();

let expected = read_to_string(output);
let _is_really_expected = expected.is_ok();
let expected = expected.unwrap_or_default();
let expected = output;

let expected_src = Tester::run(|tester| {
let expected_module = tester.apply_transform(noop(), "expected.js", syntax, &expected)?;
let expected_module = tester.apply_transform(noop(), "expected.js", syntax, expected)?;

let expected_src = tester.print(&expected_module, &Default::default());

Expand Down Expand Up @@ -411,8 +409,8 @@ where

Ok(actual_src)
})
.1
.to_string();
.0
.unwrap();

assert_eq!(
expected_src, actual_src,
Expand Down