feat(swc/wasm): expose async facade interfaces #5352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
feat-wasm-async-interface
branch
from
508e9c4 to
9576e7e
Compare
Member
Author
|
@kdy1 yup, should be resolved by now. |
kdy1
approved these changes
Aug 1, 2022
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements, exposes counterpart of
*Syncinterfaces to@swc/wasm, as same as@swc/core. It'll allow@swc/wasmbecomes near-complete drop in replacement to@swc/coreas much as possible.One important thing to note is, even though those are async interfaces there aren't any actual async implementation in place. In short, this is pretty much similar to JS-side facade wrap like
new Promise(() => swcSync()), which only wraps sync interfaces to async. The only difference is it is exposed in bindgen level, so we don't need to come up with some custom binding wrapper to make things work.Once there is support for the thread / async in wasm with standard support we'll update those internals accordingly. We do not expect to try some workaround approach like using bindgen with workers, etcs at this moment.
BREAKING CHANGE:
Related issue (if exists):