fix(ecma_parser) Allow arrow func without parenthesisised param in conditional for TS #4138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamtetlow
changed the title
kdy1
approved these changes
Mar 23, 2022
swc-bot
reviewed
Mar 23, 2022
|
Thanks for fixing this, @williamtetlow! |
|
FYI, we just reverted microsoft/TypeScript#47550 for TS 4.7 (in microsoft/TypeScript#48940), as it caused some unexpected breaks (with plans to solve it for real in 4.8). So, you my want to back this one out. |
|
Ah yep we had the same bug 😆 we've fixed that case and one other on our side and haven't seen any other issues come in @kdy1 I'll let you decide whether we pull this or leave it in seeing as it will be released in 4.8? |
|
I think it's better to revert this and #4302 for now |
|
Cool I can submit PR later today |
|
Thank you! I was busy due to the new minifier rule :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #2174, #4067
In #3685 (comment) we removed TS support for arrow function without parenthesis on single param to match the behaviour of TSC.
As of microsoft/TypeScript#47550 TSC supports this syntax.
This PR adds support for syntax.
BREAKING CHANGE:
Related issue (if exists):