-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
perf(es/parser): remove OneDirectionalList and reduce allocation of Vec
#11000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CodSpeed Performance ReportMerging #11000 will degrade performances by 3.51%Comparing Summary
Benchmarks breakdown
|
This comment was marked as resolved.
This comment was marked as resolved.
**Description:** There could be no need to clone entire lexer and parser when calling `try_parse_xxx` in typescript. Here introduces checkpoints which only contains necessary data to recover from failed trials. This is also the prerequisite for #11000. And we can also remove the `Rc<RefCell<T>>` in the lexer later I'm not sure the data is completed for correctness. Let's see the test results.
3dc46df to
a5a6315
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
kdy1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase?
e3be49b to
d712bc4
Compare
Description:
CommentsBufferinto legacy and new ones withCommentsBufferTrait.OneDirectionalListand useVec. Record positions inLexerCheckpointfor recovery.There's regression for legacy lexer. I'm not sure the reason.