Skip to content

perf(es/minifier): Remove needless clone #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

perf(es/minifier): Remove needless clone #10949

merged 1 commit into from
Jul 28, 2025

Conversation

@bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jul 28, 2025

No description provided.

@bvanjoi bvanjoi requested a review from a team as a code owner July 28, 2025 07:10
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a49190a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10949 will not alter performance

Comparing bvanjoi:parse-error (a49190a) with main (40a1e2e)

Summary

✅ 140 untouched benchmarks

@kdy1
Copy link
Member

kdy1 commented Jul 28, 2025

image It seems to regress the perf?

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Jul 28, 2025

please see the latest change.

@kdy1 kdy1 changed the title pref(es/minifier): rm useless compute bitflags perf(es/minifier): Remove needless clone Jul 28, 2025
@kdy1 kdy1 enabled auto-merge (squash) July 28, 2025 13:58
@kdy1 kdy1 merged commit b5e5e8c into swc-project:main Jul 28, 2025
320 of 322 checks passed
@kdy1 kdy1 added this to the v1.13.3 milestone Jul 29, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v1.13.3

Development

Successfully merging this pull request may close these issues.

2 participants

@bvanjoi @kdy1