Skip to content

perf(es/lexer): Remove option for handler #10881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

perf(es/lexer): Remove option for handler #10881

merged 2 commits into from
Jul 21, 2025

Conversation

@CPunisher
Copy link
Member

@CPunisher CPunisher commented Jul 17, 2025 •
edited
Loading

Description:

There's already a ERR byte handler

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c7bfb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Jul 17, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10881 will not alter performance

Comparing CPunisher:07-17-perf/option-handler (3c7bfb1) with dev/rust (82f5140)

Summary

✅ 140 untouched benchmarks

@kdy1 kdy1 deleted the branch swc-project:dev/rust July 17, 2025 14:57
@kdy1 kdy1 closed this Jul 17, 2025
@magic-akari
Copy link
Member

magic-akari commented Jul 17, 2025

This appears to be an unexpected closure triggered by the deletion of the target branch.

@kdy1 kdy1 reopened this Jul 17, 2025
@CPunisher
Copy link
Member Author

CPunisher commented Jul 18, 2025

I will rebase and merge after #10880. That pr is more complex.

@CPunisher CPunisher force-pushed the 07-17-perf/option-handler branch from 9f6d0b4 to d3ad22a Compare July 21, 2025 03:58
@CPunisher CPunisher marked this pull request as ready for review July 21, 2025 05:45
@CPunisher CPunisher requested a review from a team as a code owner July 21, 2025 05:45
@kdy1 kdy1 merged commit cec4e9e into swc-project:dev/rust Jul 21, 2025
170 of 171 checks passed
@CPunisher CPunisher deleted the 07-17-perf/option-handler branch July 21, 2025 08:49
kdy1 pushed a commit that referenced this pull request Jul 21, 2025
@CPunisher @kdy1
perf(es/lexer): Remove option for handler (#10881)
b31af7e 
**Description:**

There's already an `ERR` byte handler
@kdy1 kdy1 removed this from the Planned milestone Jul 21, 2025
kdy1 pushed a commit that referenced this pull request Jul 21, 2025
@CPunisher @kdy1
perf(es/lexer): Remove option for handler (#10881)
819a60d 
**Description:**

There's already an `ERR` byte handler
kdy1 pushed a commit that referenced this pull request Jul 21, 2025
@CPunisher @kdy1
perf(es/lexer): Remove option for handler (#10881)
66d266a 
**Description:**

There's already an `ERR` byte handler
kdy1 pushed a commit that referenced this pull request Jul 22, 2025
@CPunisher @kdy1
perf(es/lexer): Remove option for handler (#10881)
50518c1 
**Description:**

There's already an `ERR` byte handler
kdy1 pushed a commit that referenced this pull request Jul 22, 2025
@CPunisher @kdy1
perf(es/lexer): Remove option for handler (#10881)
1ad8506 
**Description:**

There's already an `ERR` byte handler
@kdy1 kdy1 added this to the v1.13.2 milestone Jul 22, 2025
@kdy1 kdy1 mentioned this pull request Jul 29, 2025
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

v1.13.2

Development

Successfully merging this pull request may close these issues.

3 participants

@CPunisher @magic-akari @kdy1