fix(es/compat): Properly handle rest assignment in for-in/of RHS #10878
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kdy1
approved these changes
Jul 17, 2025
Member
kdy1
left a comment
kdy1
left a comment
There was a problem hiding this comment.
Thanks! I’ll merge it and publish a new version later today!
CodSpeed Performance ReportMerging #10878 will not alter performanceComparing Summary
|
2 tasks
Member
|
Github is broken? I cannot merge this PR for an unknown reason |
Member
I'll merge this later when this issue is resolved |
auto-merge was automatically disabled
July 17, 2025 14:32
Pull Request is not mergeable
Member
|
@mischnic I'm sorry, but can you create another PR if it's urgent? |
Contributor
Author
|
It's not urgent, but I created a new one |
kdy1
pushed a commit
that referenced
this pull request
Jul 18, 2025
) **Description:** Remake of #10878 Fix a panic ``` thread 'main' panicked at /Users/niklas/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swc_ecma_compat_es2015-22.0.0/src/destructuring.rs:419:52: internal error: entered unreachable code: Object rest pattern should be removed by es2018::object_rest_spread pass note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` **Related issue:** Closes #10877
mischnic
added a commit
to vercel/next.js
that referenced
this pull request
Jul 23, 2025
So what do we need to do about swc-project/swc#10813? Not sure when we'd call `global_atom_store_gc()` https://vercel.slack.com/archives/C03EWR7LGEN/p1752228740427529 The 2s-debounced gc calls didn't have a measurable effect on `next build --turbo`: ``` with gc: 360.90s user 80.74s system 688% cpu 1:04.15 total 357.24s user 82.61s system 664% cpu 1:06.23 total without gc: 360.51s user 80.48s system 698% cpu 1:03.16 total 355.21s user 79.99s system 667% cpu 1:05.18 total ``` - [x] ~~Blocked on swc-project/swc#10878 - [ ] swc-project/swc#10930 Closes #81898
lukesandberg
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 24, 2025
So what do we need to do about swc-project/swc#10813? Not sure when we'd call `global_atom_store_gc()` https://vercel.slack.com/archives/C03EWR7LGEN/p1752228740427529 The 2s-debounced gc calls didn't have a measurable effect on `next build --turbo`: ``` with gc: 360.90s user 80.74s system 688% cpu 1:04.15 total 357.24s user 82.61s system 664% cpu 1:06.23 total without gc: 360.51s user 80.48s system 698% cpu 1:03.16 total 355.21s user 79.99s system 667% cpu 1:05.18 total ``` - [x] ~~Blocked on swc-project/swc#10878 - [ ] swc-project/swc#10930 Closes #81898
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix a panic
Related issue:
Closes #10877