Skip to content

Conversation

@hardfist
Copy link
Collaborator

@hardfist hardfist commented Jul 4, 2025

Description:
setting default-features=false for swc usage to avoid introduce unnecessary lint and es3 code for consumers
BREAKING CHANGE:
yes for swc and swc_core crate api

Related issue (if exists):

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: fd1c7ff

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #10776 will not alter performance

Comparing hardfist:yj/try-empty-feature (fd1c7ff) with main (5fe4629)

Summary

✅ 141 untouched benchmarks

@hardfist hardfist force-pushed the yj/try-empty-feature branch 3 times, most recently from dbe7b4b to c6901e0 Compare July 7, 2025 05:17
@socket-security
Copy link

socket-security bot commented Jul 7, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@hardfist hardfist force-pushed the yj/try-empty-feature branch from c6901e0 to 6d3e6bf Compare July 7, 2025 06:34
@hardfist hardfist marked this pull request as ready for review July 7, 2025 07:06
@hardfist hardfist requested a review from a team as a code owner July 7, 2025 07:06
@hardfist hardfist changed the title fix: make default_features empty by default fix: setting default-features=false for swc crate usage Jul 7, 2025
@kdy1 kdy1 added this to the Planned milestone Jul 7, 2025
@kdy1 kdy1 changed the title fix: setting default-features=false for swc crate usage fix(es): Use default-features = false for swc crate usages Jul 7, 2025
kdy1
kdy1 previously approved these changes Jul 7, 2025
@kdy1 kdy1 merged commit 50b2eac into swc-project:main Jul 7, 2025
4 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.12.11 Jul 8, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants