Skip to content

fix(formatjs): Use default parser options #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cuyl
Copy link
Contributor

@cuyl cuyl commented Aug 7, 2025

  • enable requires_other_clause and should_parse_skeletons by default
  • follow default behavior of @formatjs/icu-messageformat-parser

ref: https://github.com/formatjs/formatjs/blob/e11b9b57a5ed745584b169c13b0a1812ba9e6051/packages/icu-messageformat-parser/index.ts#L41-L42

Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: 5d1bab5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@momesana
Copy link

momesana commented Aug 8, 2025

I tested the patch locally (though I had rebased your branch on top of the tip of the target master branch before building) and it works fine and fixed the issue I had described here when running this with ast: true.

- enable `requires_other_clause` and `should_parse_skeletons` by default
- follow default behavior of `@formatjs/icu-messageformat-parser`
@cuyl cuyl force-pushed the fix-default-parser-options branch from fbb1578 to 5d1bab5 Compare August 9, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants