This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
data-control: Don't send offers to the clients that sent them #2408
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client is listening for offers and sends an offer, it will block forever when it attempts to receive the offer and read from the file descriptor. This is because the offer is sent back to the client that sent it. Since the writing and reading ends are in the same client, it never has a chance to write (barring methods to work around this problem). Even if the client could read its own selection, it is pointless to do so. Here we fix the problem by not making offers back to the client that sent them. The protocol has been updated to reflect this change. Closes swaywm#2406.
|
This breaks backwards compatibility and is inconsistent with the core Wayland protocol. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client is listening for offers and sends an offer, it will block forever
when it attempts to receive the offer and read from the file descriptor. This
is because the offer is sent back to the client that sent it. Since the writing
and reading ends are in the same client, it never has a chance to write
(barring methods to work around this problem). Even if the client could read
its own selection, it is pointless to do so.
Here we fix the problem by not making offers back to the client that sent them.
The protocol has been updated to reflect this change.
Closes #2406.