Skip to content

Commit

Permalink
config/output: Remove initial values in find_output_config
Browse files Browse the repository at this point in the history
Starting by setting some special initial output config values settings
was something sway used to do when the config was initially being
processed. This was later changed to always happen, as there shouldn't
be differences in how output config is calculated during config load and
after.

Most of these values are redundant, as they are either the zero value or
a value that would be selected if the unset (-1) value was found.

For output transforms, the automatic panel orientation code would only
trigger if the final output config has an unset transform, which the
initial values set in find_output_config made impossible.

Remove these initial values and instead use a fresh output config as is.
  • Loading branch information
kennylevinsen committed Oct 20, 2024
1 parent af0d4a0 commit 17ecb9e
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions sway/config/output.c
Original file line number Diff line number Diff line change
Expand Up @@ -587,15 +587,6 @@ static struct output_config *find_output_config_from_list(
return NULL;
}

// Set output defaults for the "base" configuration
result->enabled = 1;
result->power = 1;
result->scale = 0; // auto
result->subpixel = sway_output->detected_subpixel;
result->transform = WL_OUTPUT_TRANSFORM_NORMAL;
result->max_render_time = 0;
result->allow_tearing = 0;

char id[128];
output_get_identifier(id, sizeof(id), sway_output);

Expand Down

0 comments on commit 17ecb9e

Please sign in to comment.