Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch filter to reduce CI cost #488

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Add branch filter to reduce CI cost #488

merged 3 commits into from
Jun 25, 2022

Conversation

TristanCacqueray
Copy link
Collaborator

The action presently runs twice because both on conditions matche
every contributions. With this change, the push action only triggers
for the final push to the main branch, and the pull_requeste action
only triggers for PR made for the main branch.

That also means restyled PR should not trigger CI as they are made
for non main branches.

The action presently runs twice because both `on` condition matches
every contribution. With this change, the push action only triggers
for the final push to the main branch, and the pull_requestion action
only triggers for PR made for the main branch.

That also means restyled PR should not trigger CI as they are made
for non main branches.
@byorgey
Copy link
Member

byorgey commented Jun 25, 2022

The CI didn't seem to run at all for this PR, is that expected?

@TristanCacqueray
Copy link
Collaborator Author

Yes that was expected, the workflow file was not matched.

Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good to me.

@TristanCacqueray TristanCacqueray added the merge me Trigger the merge process of the Pull request. label Jun 25, 2022
@mergify mergify bot merged commit 15b758b into main Jun 25, 2022
@mergify mergify bot deleted the reduce-ci branch June 25, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants