Use forM_/mapM_ #2273
Merged
Use forM_/mapM_ #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
refactor/forM-replacement
branch
from
bb8122b to
fa4d9b5
Compare
kostmo
changed the base branch from
refactor/ui-gameplay-optional-part1
to
main
kostmo
added
the
Z-Refactoring
byorgey
approved these changes
Jan 6, 2025
| case capProviders of | ||
| Nothing -> throwError $ Incapable FixByEquip (R.singletonCap cap) (TConst c) | ||
| Just rawCosts -> payExerciseCost c rawCosts | ||
| gets @Robot (constCapsFor c) >>= mapM_ go |
There was a problem hiding this comment.
Out of curiosity, does it work to write gets @Robot (constCapsFor c) >>= mapM_ \cap -> do ... ? Either is fine though.
There was a problem hiding this comment.
Yes, that works, and I've changed it. However, I was unable to make the same change here (perhaps due to the $ operator).
kostmo
commented
Jan 6, 2025
Comment on lines
+97
to
+99
| getNormalizedCurrentScenarioPath >>= mapM_ go | ||
| where | ||
| go p = do |
There was a problem hiding this comment.
cannot inline the lambda here
kostmo
force-pushed
the
refactor/forM-replacement
branch
from
fa4d9b5 to
d58d237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searched for instances of
return ()andpure (), especiallyNothing -> return (), which uncovered several opportunities to usewhen/unlessandmapM_/forM_.