Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate subworld names of explicitly located robots #1875

Merged
merged 1 commit into from
May 29, 2024
Merged

validate subworld names of explicitly located robots #1875

merged 1 commit into from
May 29, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented May 29, 2024 •
edited
Loading

Demo

scripts/test/run-tests.sh --test-options '--pattern "1875-robot-subworld-location"'

and

scripts/play.sh -i data/scenarios/Testing/144-subworlds/subworld-shared-structures.yaml --autoplay

@kostmo kostmo force-pushed the feature/validate-robot-subworld branch 2 times, most recently from 4669c03 to 1053667 Compare May 29, 2024 06:03
@kostmo kostmo added the Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. label May 29, 2024
@kostmo kostmo requested a review from byorgey May 29, 2024 06:04
@kostmo kostmo marked this pull request as ready for review May 29, 2024 06:05
byorgey
byorgey approved these changes May 29, 2024
View reviewed changes
src/swarm-scenario/Swarm/Game/Scenario.hs Outdated Show resolved Hide resolved
src/swarm-scenario/Swarm/Game/Scenario.hs Outdated Show resolved Hide resolved
@kostmo kostmo force-pushed the feature/validate-robot-subworld branch from 1053667 to 44c0f0d Compare May 29, 2024 16:27
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label May 29, 2024
@mergify mergify bot merged commit 834f549 into main May 29, 2024
13 checks passed
@mergify mergify bot deleted the feature/validate-robot-subworld branch May 29, 2024 16:44
@kostmo kostmo added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey