Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dim sum restaurant #1686

Merged
merged 2 commits into from
Dec 15, 2023
Merged

dim sum restaurant #1686

merged 2 commits into from
Dec 15, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Dec 14, 2023 

scripts/play.sh -i scenarios/Challenges/dimsum.yaml --autoplay

Screenshot from 2023-12-13 22-39-53

@kostmo kostmo added the G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. label Dec 14, 2023
@kostmo kostmo marked this pull request as ready for review December 14, 2023 06:48
@kostmo kostmo requested a review from byorgey December 14, 2023 06:48
@kostmo kostmo force-pushed the scenario/dimsum branch 2 times, most recently from 235caa6 to 3a51214 Compare December 14, 2023 06:57
byorgey
byorgey approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My solution was very similar to the "official" solution except I thought I had to do it without using recursion --- see my comment. 😄

data/entities.yaml Show resolved Hide resolved
data/scenarios/Challenges/_dimsum/patron.sw Show resolved Hide resolved
data/scenarios/Challenges/_dimsum/solution.sw Show resolved Hide resolved
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Dec 15, 2023
@mergify mergify bot merged commit 53e6f35 into main Dec 15, 2023
9 checks passed
@mergify mergify bot deleted the scenario/dimsum branch December 15, 2023 04:49
@byorgey byorgey added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey