-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to scrolling #1481
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5122ac8
add scrollbars to inventory + info panels
byorgey bfcf72c
add scrolling to REPL
byorgey af4de3c
scroll REPL to end automatically
byorgey 4a86cd5
add keybinding hint for REPL scroll
byorgey f8fd240
add proper spacing on the left of scroll bars
byorgey 57813aa
Merge branch 'main' into feature/scroll-repl
byorgey fefbe86
depend on `brick-1.10` and `brick-list-skip-0.1.1.5`
byorgey 0b08a3b
cache REPL history
byorgey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
cache REPL history
I think this is the proper way to do things: we give the entire REPL history to brick so that it can render the entire thing and thus draw the scroll bar correctly, scroll through the history with PgUp/PgDown etc., but we cache it so that it is only re-rendered when the history changes (i.e. when a new input is entered, or a new output becomes available).
- Loading branch information
commit 0b08a3b702d1734cbc7c9257e61b2cda90818049
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This vBox of empty list is a neat trick, I am surprised it does not produce an empty line. 🤔
@byorgey I noticed I can no longer click in the middle of the REPL to focus on it, only the edges work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I looked into this for a while but can't figure it out. It seems like after making the REPL into a scrollable viewport, click events are no longer generated for any clicks in the interior of the panel. I'm wondering if it's a brick bug. I might just split this out into another issue and investigate it later.