Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight ticks per frame in red when it reaches the cap #1386

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Highlight ticks per frame in red when it reaches the cap #1386

merged 2 commits into from
Jul 20, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jul 20, 2023

Closes #1348.

@byorgey byorgey requested a review from kostmo July 20, 2023 16:02
@kostmo
Copy link
Member

kostmo commented Jul 20, 2023

Can you share a "test plan" to reproduce hitting the cap and demo the new behavior?

@noahyor
Copy link
Member

noahyor commented Jul 20, 2023 •
edited
Loading

Running Swarm with any scenario and increasing the speed is a good way to reproduce this.

@kostmo
Copy link
Member

kostmo commented Jul 20, 2023

For reference, here were the exact steps I took:

  1. Launch with: 
    scripts/play.sh --scenario classic --speed 10
  2. Press Meta-w to focus the world view
  3. Press f to show the FPS indicator, observe red display
  4. Press z to halve the speed, observe display become white

Screenshot from 2023-07-20 10-56-26

@noahyor noahyor added the merge me Trigger the merge process of the Pull request. label Jul 20, 2023
@mergify mergify bot merged commit d1a8242 into main Jul 20, 2023
@mergify mergify bot deleted the show-framerate-slowdown2 branch July 20, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draw framerate slowdown indicator
3 participants
@byorgey @kostmo @noahyor