-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More typechecking error message improvements #1308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `expect` to `unify` - Add a `Syntax` argument to all `decomposeXXX` functions - Add `Source` and `Join` machinery to properly keep track of which type is "expected" and which is "actual"
This helps with error messages for multi-argument polymorphic function application (e.g. `if`).
Co-authored-by: Restyled.io <commits@restyled.io>
FYI rebasing on |
kostmo
approved these changes
Jun 9, 2023
Co-authored-by: Karl Ostmo <kostmo@gmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1297 . In this PR:
Pipeline
and into more appropriate modulesJoin
to represent two types or other things, one "expected" and one "actual", at the point where they join + we check whether they are equal; a bunch of refactoring to use this new type. This way we don't have to remember which argument is which when calling a function that takes one "expected" thing and one "actual" thing.decomposeXXX
functions to take aSyntax
node to use in error messages, and to take aSourced UType
(i.e. aUType
along with whether it is "expected" or "actual") instead of just aUType
so we can generate accurate error messagesfoo
". Currently this is just a basic proof of concept.