Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drill command returns first inventory addition #1165

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Drill command returns first inventory addition #1165

merged 2 commits into from
Mar 18, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Mar 18, 2023

Closes #1157

Demo:

scripts/play.sh --scenario data/scenarios/Testing/1157-drill-return-value.yaml --autoplay

@kostmo kostmo force-pushed the drill-return-value branch from 7965c10 to cf04313 Compare March 18, 2023 05:41
@kostmo kostmo marked this pull request as ready for review March 18, 2023 05:42
@kostmo kostmo requested a review from byorgey March 18, 2023 05:42
byorgey
byorgey approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we also update the description of the drill entity at all?

@kostmo
Copy link
Member Author

kostmo commented Mar 18, 2023

update the description

Maybe not the "entity", but I have now also added to the description of the drill command.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Mar 18, 2023
@byorgey
Copy link
Member

byorgey commented Mar 18, 2023

Maybe not the "entity", but I have now also added to the description of the drill command.

Ah, that makes sense. Some entity descriptions include examples of using associated commands, but I see that is not the case with the drill.

@mergify mergify bot merged commit c4cbed6 into main Mar 18, 2023
@mergify mergify bot deleted the drill-return-value branch March 18, 2023 18:44
kostmo added a commit that referenced this pull request Mar 19, 2023
@kostmo
add missing file
3bd8190 
follow-up to #1165
@kostmo kostmo mentioned this pull request Mar 19, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 19, 2023
@kostmo
add missing file to 00-ORDER (#1167)
c69de6f 
follow-up to #1165
@kostmo kostmo mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drill command should return the name of the entity obtained
2 participants
@kostmo @byorgey