Move Heading and conversions to Location module #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
byorgey
approved these changes
Feb 12, 2023
src/Swarm/Game/Location.hs
Outdated
| DAbsolute e -> cardinal $ toHeading e | ||
| where | ||
| cardinal = const | ||
| relative = id |
There was a problem hiding this comment.
What is the point of defining relative = id? Why not just have DLeft -> perp and so on? (Maybe this code was already like that but I didn't notice before.)
There was a problem hiding this comment.
No good reason, I think we originally used it for the absolute/relative distinction, but that has disappeared with the direction constructors.
src/Swarm/Language/Syntax.hs
Outdated
|
|
||
| cardinal = DirInfo directionSyntax . const | ||
| relative = DirInfo directionSyntax | ||
| -- | Direction name is generate from Direction data constuctor |
There was a problem hiding this comment.
Suggested change
| -- | Direction name is generate from Direction data constuctor | |
| -- | Direction name is generated from Direction data constuctor |
kostmo
reviewed
Feb 12, 2023
src/Swarm/Game/Location.hs
Outdated
| applyTurn d = case d of | ||
| DRelative e -> case e of | ||
| DLeft -> relative perp | ||
| DRight -> relative (fmap negate . perp) |
There was a problem hiding this comment.
I've been meaning to replace fmap negate with just negated
kostmo
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirInfotypeDirection -> Headingfunctions to theLocationmodule