Updated playergamelogs endpoint to include four new parameters to run…#629
Open
eac521 wants to merge 2 commits intoswar:masterfrom
Open
Updated playergamelogs endpoint to include four new parameters to run…#629eac521 wants to merge 2 commits intoswar:masterfrom
eac521 wants to merge 2 commits intoswar:masterfrom
Conversation
…: Rank, PaceAdjust, ISTRound and PlusMinus
Owner
|
Your MR will need some cleanup. The |
… file with proper Nullable classes. Removed out superflous DS_Store files.
Author
|
Thanks for your patience with me and creating this repo! it is really a fantastic setup and has helped me a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: JSONDecodeError / timeout when calling PlayerGameLogs
Missing: NBA.com now requires ISTRound, PaceAdjust, PlusMinus, Rank parameters
Action: These parameters are added into the playergamelogs params dictionary, these parameters were found by going to the nba.com/stats site and finding the api and comparing the url to the previous
testing: api has worked 1/11/2026 and 1/12/2026 data