Conversation
|
@rsforbes can you review this? |
brandonhawi
left a comment
There was a problem hiding this comment.
Left some comments, but overall looks good 👍🏼
|
@brandonhawi |
|
@brandonhawi I reflected the review |
brandonhawi
left a comment
There was a problem hiding this comment.
Thanks so much for your contributions. Left one small documentation comment but otherwise awesome work!
Co-authored-by: Brandon Hawi <brandonhawi1@gmail.com>
|
@brandonhawi thank you. I commited your comment |
|
Any update here? |
brandonhawi
left a comment
There was a problem hiding this comment.
Looks good, another small nitpick
|
@brandonhawi thx. I made a commit |
|
My apologies for my lack of response here. Just some questions so I can get the context on here:
And is the following code below accurate when trying test it out? result = dunkscoreleaders.DunkScoreLeaders(
season="2025-26",
)
print(result.get_dict()) |
|
@swar thanks for comment.
Before the change, a custom parser was not implemented, and it referenced a key named
From Dunks -> dunks. rawResponse on the issue. As I am not a native English speaker, the precise nuances may not be entirely accurate. |
I've checked as below. team_id and player_id looks *required params. from nba_api.stats.endpoints.dunkscoreleaders import DunkScoreLeaders
result = DunkScoreLeaders(
season="2025-26",
team_id_nullable="1610612737",
player_id_nullable="1630168",
)
print(result.get_dict()) |
|
I caused a conflict with this branch. If you are unable to resolve it, I can take look into resolving it when the next release goes out. Thank you @poteto0! |
|
thanks @swar I dealed w/ conflict |
I'm not sure that best response structure, but this resolve issue.
resolve issue as below