Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New official pool support / nftpool support #1224

Merged
merged 17 commits into from
Jul 9, 2021
Merged

New official pool support / nftpool support #1224

merged 17 commits into from
Jul 9, 2021

Conversation

jack60612
Copy link
Contributor

The new pool_url variable allows the use of Pool Contract Address
Refer to
https://github.com/Chia-Network/chia-blockchain/wiki/Pooling-FAQ#how-do-i-assign-portable-plots-to-a-pool

Tested and working on linux and windows

@jack60612
Copy link
Contributor Author

@swar

@mladenperisic
Copy link

@jack60612 Hey, Jack! I like this PR! How about you merge this PR https://github.com/swar/Swar-Chia-Plot-Manager/pull/1139/files from @jchristman75 in your fork?

@jack60612
Copy link
Contributor Author

@mladenperisic i do understand where you are coming from. however i would like to get this fork merged as soon as possible so i'm probably not going to do that

@jack60612 jack60612 mentioned this pull request Jul 5, 2021
@jack60612 jack60612 changed the title New official pool support New official pool support / nftpool support Jul 5, 2021
@TomasVelPar
Copy link
Contributor

@jack60612 thank you so much. I have made those modifications to the original code and its working for me.

@adobito
Copy link

adobito commented Jul 9, 2021

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error
RuntimeError: Choose one of pool_contract_address and pool_public_key
but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

@TomasVelPar
Copy link
Contributor

I think you must delete (or comment) your pool_public_key, and is not the pool url, its your pool contract address (you can obtaint it making a plot with chia gui, deleting it after few seconds and checking que plot log).

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error
RuntimeError: Choose one of pool_contract_address and pool_public_key
but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

@adobito
Copy link

adobito commented Jul 9, 2021

I think you must delete (or comment) your pool_public_key, and is not the pool url, its your pool contract address (you can obtaint it making a plot with chia gui, deleting it after few seconds and checking que plot log).

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error
RuntimeError: Choose one of pool_contract_address and pool_public_key
but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

The point I was trying to make is that this is a problem and the plot manager should catch this.

@jack60612
Copy link
Contributor Author

I think you must delete (or comment) your pool_public_key, and is not the pool url, its your pool contract address (you can obtaint it making a plot with chia gui, deleting it after few seconds and checking que plot log).

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error
RuntimeError: Choose one of pool_contract_address and pool_public_key
but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

yep i made this code 10 days ago before this was clear so im fixing it now

@125devin
Copy link

125devin commented Jul 9, 2021

Is it necessary to keep the 'pool_public_key' variable? Is the '-p' flag needed for anything?

Would changing one letter in the file pools.py do the trick for updating to chia 1.2 pools?

    flags['p'] = pool_public_key

to
flags['c'] = pool_public_key

Would the pool_public_key variable in the config.yaml file then work for the new "pool contract key"?

@jack60612
Copy link
Contributor Author

Is it necessary to keep the 'pool_public_key' variable? Is the '-p' flag needed for anything?

Would changing one letter in the file pools.py do the trick for updating to chia 1.2 pools?

    flags['p'] = pool_public_key

to
flags['c'] = pool_public_key

Would the pool_public_key variable in the config.yaml file then work for the new "pool contract key"?

Backwards compatibility
If swar wants he can remove it but i dont think its my place to

@swar
Copy link
Owner

swar commented Jul 9, 2021

@jack60612 can you add a placeholder to the Russian README as well and I will get this merged out soon

@jack60612
Copy link
Contributor Author

@jack60612 can you add a placeholder to the Russian README as well and I will get this merged out soon

added

@swar swar merged commit 0456d9f into swar:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants