-
Notifications
You must be signed in to change notification settings - Fork 9
DOC-704 Suspended card renewals #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for incomparable-tiramisu-91a96a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e3cc104
to
5368a71
Compare
docs/topics/cards/physical/index.mdx
Outdated
@@ -302,6 +302,20 @@ The four-digit **PIN doesn't change** for a continuous user experience. | |||
If your user prefers to [choose their PIN](#pin-choose), they need to [cancel the expiring card](./guide-cancel.mdx) and order a new one. | |||
It's not possible to choose a new PIN during renewal. | |||
|
|||
### Suspended physical cards {#renew-suspended} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going from the feedback recently about terminology - is "resumed" a status in itself? Or are we using it as the opposite of suspended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resumed is a mutation for physical cards, not a status.
docs/topics/cards/physical/index.mdx
Outdated
| Resumed more than 10 weeks before expiry | `ToRenew` → `Renewed` | Renewed | | ||
| Not resumed more than 10 weeks before expiry | Remains `Suspended` | Not renewed, cancelled at expiry | | ||
| Resumed between 10 and 8 weeks before expiry | `ToRenew` → `Renewed` | Renewed | | ||
| Not resumed between 10 and 8 weeks before expiry | Remains `Suspended` | Not renewed, cancelled at expiry | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 8 and 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, we're talking about card renewal deadlines, so we’re counting backwards towards the expiry date.
-
Saying “between 10 and 8 weeks before expiry” makes sense because we’re talking about the window that starts 10 weeks before expiry and ends 8 weeks before expiry. The
ToRenew
period. -
Flipping it to “between 8 and 10 weeks” implies we're moving forward in time, which doesn’t match the logic of a countdown to expiry.
docs/topics/cards/physical/index.mdx
Outdated
|
||
The renewal process for a suspended physical card depends on when the card is **resumed**. | ||
|
||
| Scenario | Card status after suspension | Card renewal outcome | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the table be:
If you... | More than 8 weeks before expiry | Less than 8 weeks before expiry |
---|---|---|
Resume the card | The card is renewed automatically. | The card is not renewed and will be Canceled at expiry. |
Do not resume the card | The card is not renewed and will be Canceled at expiry. | The card is not renewed and will be Canceled at expiry. |
Easier to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this structure, it’s much clearer and easier to follow, so I’ll use it as a base. That said, it’s still missing some specific use cases, and it doesn’t include the detailed status transitions, which have been a recurring point of confusion for partners. I’ll check in with Nelson or Arnaud to clarify the details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes for clarity.
61a2d3d
to
ce21658
Compare
| Suspended and not resumed more than **10 weeks** before expiry | `Suspended` | `Suspended` | `Canceled` | | ||
| Suspended and resumed between **10 and 8 weeks** before expiry | `ToRenew` | `Renewed` | `Renewed` | | ||
| Suspended and not resumed between **10 and 8 weeks** before expiry | `ToRenew` | `Suspended` | `Canceled` | | ||
| Suspended between **10 and 8 weeks** before expiry and resumed less than **8 weeks** before expiry | `ToRenew` | `Suspended` | `Canceled` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs a comma after the first before expiry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go - just that one comma.
This is part of the card renewal PIM request. Here's the linear ticket.
Thank you!