Skip to content

Commit

Permalink
Compile nbextension into 'nbextension' directory instead of 'static'
Browse files Browse the repository at this point in the history
  • Loading branch information
diocas committed Jan 18, 2024
1 parent 61f6c35 commit ea6c515
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ node_modules/
.ipynb_checkpoints
*.tsbuildinfo
sparkmonitor/labextension
sparkmonitor/static
sparkmonitor/nbextension
scalalistener/project/
scalalistener/target/
sparkmonitor/*.jar
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"clean:lib": "rimraf lib tsconfig.tsbuildinfo",
"clean:lintcache": "rimraf .eslintcache .stylelintcache",
"clean:labextension": "rimraf sparkmonitor/labextension sparkmonitor/_version.py",
"clean:nbextension": "rimraf sparkmonitor/static",
"clean:nbextension": "rimraf sparkmonitor/nbextension",
"clean:scalalistener": "rimraf sparkmonitor/*.jar",
"clean:all": "jlpm clean:lib && jlpm clean:labextension && jlpm clean:nbextension && jlpm clean:scalalistener && jlpm clean:lintcache",
"eslint": "jlpm eslint:check --fix",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ build-function = "hatch_jupyter_builder.npm_builder"
ensured-targets = [
"sparkmonitor/labextension/static/style.js",
"sparkmonitor/labextension/package.json",
"sparkmonitor/static/extension.js",
"sparkmonitor/nbextension/extension.js",
"sparkmonitor/listener_2.11.jar",
"sparkmonitor/listener_2.12.jar",
]
Expand Down
2 changes: 1 addition & 1 deletion sparkmonitor/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def _jupyter_nbextension_paths():
return [dict(
section='notebook',
# the path is relative to the `my_fancy_module` directory
src='static',
src='nbextension',
# directory in the `nbextension/` namespace
dest='sparkmonitor',
# _also_ in the `nbextension/` namespace
Expand Down
2 changes: 1 addition & 1 deletion src/notebook-extension/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const config = {
extension: path.join(__dirname, 'entry.js'),
},
output: {
path: path.join(__dirname, '../../sparkmonitor/static'),
path: path.join(__dirname, '../../sparkmonitor/nbextension'),
filename: '[name].js',
libraryTarget: 'umd',
publicPath: '',
Expand Down

0 comments on commit ea6c515

Please sign in to comment.