Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: go1.16 embed.FS #16

Merged
merged 7 commits into from
Mar 20, 2023
Merged

feat: go1.16 embed.FS #16

merged 7 commits into from
Mar 20, 2023

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Dec 9, 2022

No description provided.

@ubogdan ubogdan requested a review from sdghchj December 9, 2022 00:42
@ubogdan
Copy link
Contributor Author

ubogdan commented Dec 9, 2022

@sdghchj Please let me know if you have other idea here.

@sdghchj
Copy link
Member

sdghchj commented Dec 9, 2022 •
edited
Loading

I know little about this project, so I can only help approve it without a review.

@rhaist
Copy link
Contributor

rhaist commented Dec 15, 2022

Two suggestions:

  1. actions/setup-go@v2 should be actions/setup-go@v3
  2. Add git submodule update --recursive --remote to the build section of the Makefile to ensure the latest swagger-ui version

@Jictyvoo
Copy link

Jictyvoo commented Feb 2, 2023

any updates on merging this? I'm using pprof on a server, and detecting that the package golang.org/x/net is consuming a lot of memory, as it uses embed, maybe it can be improved.

@ubogdan ubogdan merged commit dedb217 into master Mar 20, 2023
@Jictyvoo Jictyvoo mentioned this pull request Mar 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdghchj sdghchj sdghchj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ubogdan @sdghchj @rhaist @Jictyvoo