Skip to content

Allow overriding the request validator when using NewService #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow overriding the request validator when using NewService #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions web/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,26 @@ func NewService(refl oapi.Reflector, options ...func(s *Service)) *Service {
}

validatorFactory := jsonschema.NewFactory(s.OpenAPICollector, s.OpenAPICollector)
s.ResponseValidatorFactory = validatorFactory

if s.ResponseValidatorFactory == nil {
s.ResponseValidatorFactory = validatorFactory
}

if s.RequestValidatorFactory == nil {
s.RequestValidatorFactory = validatorFactory
}

if s.PanicRecoveryMiddleware == nil {
s.PanicRecoveryMiddleware = middleware.Recoverer
}

// Setup middlewares.
s.Wrapper.Wrap(
s.PanicRecoveryMiddleware, // Panic recovery.
nethttp.OpenAPIMiddleware(s.OpenAPICollector), // Documentation collector.
request.DecoderMiddleware(s.DecoderFactory), // Request decoder setup.
request.ValidatorMiddleware(validatorFactory), // Request validator setup.
response.EncoderMiddleware, // Response encoder setup.
s.PanicRecoveryMiddleware, // Panic recovery.
nethttp.OpenAPIMiddleware(s.OpenAPICollector), // Documentation collector.
request.DecoderMiddleware(s.DecoderFactory), // Request decoder setup.
request.ValidatorMiddleware(s.RequestValidatorFactory), // Request validator setup.
response.EncoderMiddleware, // Response encoder setup.
)

return &s
Expand Down Expand Up @@ -109,6 +116,10 @@ type Service struct {
// added to service via Wrap.
ResponseValidatorFactory rest.ResponseValidatorFactory

// Request validation is enabled by default, but the default validator can be overriden by
// populating this field.
RequestValidatorFactory rest.RequestValidatorFactory

// AddHeadToGet is an option to enable HEAD method for each usecase added with Service.Get.
AddHeadToGet bool
}
Expand Down