Skip to content

Conversation

@emodric
Copy link
Contributor

@emodric emodric commented Jul 26, 2019

Hi.

We have a build that fails on PHP 7.4 due to a missing check for null.

You can see the build here: https://travis-ci.org/netgen-layouts/layouts-core/jobs/564002323

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files          27       27           
  Lines        1579     1579           
=======================================
  Hits         1426     1426           
  Misses        153      153
Impacted Files Coverage Δ
src/Schema.php 95.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a5429...bdda5fc. Read the comment docs.

@vearutop vearutop merged commit e1fcf01 into swaggest:master Aug 4, 2019
@vearutop
Copy link
Member

vearutop commented Aug 4, 2019

@emodric thank you for fixing this issue! Tagged v0.12.12.

@emodric
Copy link
Contributor Author

emodric commented Aug 4, 2019

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants