Writing defaults of class properties #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should not be any defaults in the setter methods of class properties. These should only be assigned in the initialization process of an object (constructor).
vearutop
requested changes
Jan 6, 2020
src/JsonSchema/PhpBuilder.php
Outdated
| @@ -176,6 +176,10 @@ private function makeClass($schema, $path) | |||
| $phpProperty->addMeta($property, self::SCHEMA); | |||
| $phpProperty->addMeta($name, self::PROPERTY_NAME); | |||
|
|
|||
| if (!is_null($property->default)) { | |||
There was a problem hiding this comment.
Let's make this configurable, rendering default can be unwanted in some cases, e.g. to avoid default values when encoding json.
We can have some option like this in PhpBuilder:
/**
* Use default values to initialize properties
* @var bool
*/
public $declarePropertyDefaults = false;and then
if (!is_null($property->default) && $this->declarePropertyDefaults) {
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
============================================
+ Coverage 88.23% 89.02% +0.78%
- Complexity 500 503 +3
============================================
Files 38 38
Lines 1326 1330 +4
============================================
+ Hits 1170 1184 +14
+ Misses 156 146 -10
Continue to review full report at Codecov.
|
vearutop
approved these changes
Jan 7, 2020
stephanniewerth
deleted the
feature/writing-properties-default-to-generated-class
branch
|
@derjumpy thank you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you work with the rendered classes to export data, there are no default values for the class properties. With this pull request the default values will be written to the generated files. The setter methods will not get any defaults, because this should only be done in the definition of the class properties.
Class properties (first without a default value):
Setter would be the same as before: