Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): Prevent characters from getting clipped in inputs #8216

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix(ux): Prevent characters from getting clipped in inputs #8216

merged 2 commits into from
Oct 19, 2022

Conversation

Avantgarde95
Copy link
Contributor

In some environments (ex. MS Edge on Windows), tall characters (ex. g, j) get clipped in the inputs.

Description

_normalize.scss of tachyons-sass sets line-height to 1.15.
We override the line height of the inputs.

Motivation and Context

Prevent characters from getting clipped.

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Before fix

before1

before2

After fix

after1

after2

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit a43ae1c into swagger-api:master Oct 19, 2022
@tim-lai
Copy link
Contributor

tim-lai commented Oct 19, 2022

@Avantgarde95 PR merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants