Run Handlebars within Gulp instead of NPM #2339
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First, thanks for this project. It is very convenient. 👍
Trying to tweak it a little bit, I have been a little bit confused by the fact sources written by hand are mixed with generated sources. This applies in particular to the templates.js file, which is in fact generated by Handelbars from the templates.
And what a pity to have to run Handlebars by hand or through NPM.
This pull request moves Handlebars generation from NPM into Gulp. The main advantage is that you can now directly edit Handlebars templates and see the application being live updated. We thus benefit from both Gulp watch process and Handlebars generation.
Distribution builds keep on working as previously.
The Handlebars thing just moved from NPM to Gulp.