Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@swagger-api/apidom-core@0.76.0 requires node 15 or greater, breaks Node-14 CI #3127

Closed
shazron opened this issue Sep 6, 2023 · 4 comments
Closed

@swagger-api/apidom-core@0.76.0 requires node 15 or greater, breaks Node-14 CI #3127

shazron opened this issue Sep 6, 2023 · 4 comments
Assignees
@char0n
Labels
type: regression version: 3.x

Comments

@shazron
Copy link

shazron commented Sep 6, 2023 •
edited
Loading

However this lib's version range will include it:

swagger-js/package.json

Line 117 in 1c5396a

"@swagger-api/apidom-core": ">=0.74.1 <1.0.0",

It fails Node-14 CI because @swagger-api/apidom-core@0.76.0 uses AggregateError which only occurs in Node-15.

A "fix" would be to either:

  1. polyfill this module it with https://www.npmjs.com/package/es-aggregate-error
  2. limit @swagger-api/apidom-core version range to 0.75.0 or lesser in this module's package.json
  3. fix the issue in @swagger-api/apidom-core@0.76.0 so it is compatible with Node-14 (use the shim specified above, if not available in the current node runtime)
@shazron shazron mentioned this issue Sep 6, 2023
Closed
@char0n char0n self-assigned this Sep 7, 2023
@char0n char0n mentioned this issue Sep 7, 2023
Closed
@char0n
Copy link
Member

char0n commented Sep 7, 2023

Hi @shazron,

Thanks for the report. You're absolutely right, Node.js >12.20.0 is our supported runtime for swagger-client.

Created tracking issue with ApiDOM and working on the fix: swagger-api/apidom#3128

@char0n
Copy link
Member

char0n commented Sep 7, 2023 •
edited
Loading

Backward compatibility in ApiDOM addressed in https://github.com/swagger-api/apidom/pull/3129/files and released in https://github.com/swagger-api/apidom/releases/tag/v0.76.1

@char0n char0n mentioned this issue Sep 7, 2023
Closed
char0n added a commit that referenced this issue Sep 7, 2023
@char0n
fix: use ApiDOM@0.76.1 to be further compatible with Node.js>=12.20.0
0441f9b 
Refs #3127
@char0n char0n mentioned this issue Sep 7, 2023
Merged
@char0n
Copy link
Member

char0n commented Sep 7, 2023

Addressed in this repo by #3129

char0n added a commit that referenced this issue Sep 7, 2023
@char0n
fix: use ApiDOM@0.76.1 to be further compatible with Node.js>=12.20.0 (…
34ff082 
…#3129)

Refs #3127
swagger-bot pushed a commit that referenced this issue Sep 7, 2023
@semantic-release-bot
chore(release): cut the 3.20.1 release [skip ci]
b9cc6aa 
## [3.20.1](v3.20.0...v3.20.1) (2023-09-07)

### Bug Fixes

* use ApiDOM@0.76.1 to be further compatible with Node.js>=12.20.0 ([#3129](#3129)) ([34ff082](34ff082)), closes [#3127](#3127)
@char0n
Copy link
Member

char0n commented Sep 7, 2023

Released as https://github.com/swagger-api/swagger-js/releases

@char0n char0n closed this as completed Sep 7, 2023
@MichaelGoberling MichaelGoberling mentioned this issue Sep 7, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
type: regression version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shazron @char0n