Skip to content

Conversation

@robert-hebel-sb
Copy link
Contributor

No description provided.

@robert-hebel-sb robert-hebel-sb added the enhancement New feature or request label Jan 22, 2026
@robert-hebel-sb robert-hebel-sb marked this pull request as draft January 22, 2026 09:26
@robert-hebel-sb robert-hebel-sb force-pushed the feat/add-support-for-async3-syntax-highlight branch from 6318cbe to 85b031c Compare January 22, 2026 14:54
@robert-hebel-sb robert-hebel-sb marked this pull request as ready for review January 22, 2026 14:55
{ token: 'messageTrait', foreground: '#1de2fa' },
{ token: 'operationTrait', foreground: '#1de2fa' },
// bindings: sky blue
{ token: 'channel-binding', foreground: '#1de2fa' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to https://github.com/swagger-api/apidom/pull/5106/changes#r2726621602, should we have other bindings? Also, should the parent Channel Bindings Object (and other) have a colour defined, as I see operationBindings does have it - do we have a token for it?

// bindings: sky blue
{ token: 'channel-binding', foreground: '#1de2fa' },
// AsyncAPI 3 specific: sky blue
{ token: 'operationReply', foreground: '#1de2fa' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the convention is overall for the styles but should these have the same colours as components-reply-addresses and components-replies ? E.g. channel and components-channels also have the same ones.

Add comprehensive AsyncAPI 3 binding support:
- Add channelBindings, messageBindings, and serverBindings parent tokens
- Add message-binding, operation-binding, and server-binding item tokens
- Align operationReply and operationReplyAddress colors with their
  components-* counterparts (olive green) following the established
  pattern where related tokens share styling

Addresses feedback from PR #5696 and adds missing tokens from
apidom PR #5106.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants