Docker: allow for specification of BASE_URL via container environment variable #2281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@fehguy Because you're listed as maintainer for the Dockerfile, I want to let you know about this PR. (To others, though, please note that this pattern used is identical to what is in the analogous Dockerfile for which fehguy is also listed as maintainer.)
@tim-lai thanks for categorizing the recent similar PR (#2257). If that's needed again, please do so here,
Motivation and Context
This adds the option to specify a BASE_URL at which to serve the application. As is done with Swagger UI (see it's Installation documentation), the above PR now allows specification of a BASE_URL. This allows the editor to be served at a different location (e.g. /swagger-editor), which can enable this to be served at a single URL routed via a Kubernetes Ingress object.
Fix: #1956
How Has This Been Tested?
New functionality:
docker build .docker run -e BASE_URL='/swagger-editor' -p 80:8080 [hash]Verify prior functionality without BASE_URL:
docker run -p 80:8080 [same-hash]Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests