-
Couldn't load subscription status.
- Fork 2.2k
chore: remove System.out and printStackTrace to align with Sonar rules S106 and S1148 #4988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove System.out and printStackTrace to align with Sonar rules S106 and S1148 #4988
Conversation
|
@kuntal1461 thank you for your time and contribution. I have some concerns about this PR. In addition to removing unnecessary System.out and printStackTraces, I see other changes that should not be part of this PR. For example, I see changes that are in PR #4986. There's also a configuration for VSCode that should not be added. Please correct this PR. |
5c27a71 to
8fcecf9
Compare
|
@daniel-kmiecik Please check once . and let me know if any ting I need to change . |
|
@daniel-kmiecik Please update once . |
...ipse-transformer-maven-plugin/src/main/java/io/swagger/v3/oas/transformer/TransformMojo.java
Show resolved
Hide resolved
|
@kuntal1461 please also correct the tests, as there are errors. |
|
@daniel-kmiecik Please check once . and let me know if any ting I need to change . |
...ipse-transformer-maven-plugin/src/main/java/io/swagger/v3/oas/transformer/TransformMojo.java
Outdated
Show resolved
Hide resolved
|
@kuntal1461 we really appreciate your commitment! Thank you! |
|
Hi @daniel-kmiecik Thanks! Always happy to collaborate and improve together. |
Description
This PR removes all direct usages of
System.outandprintStackTrace()to align the codebase with SonarQube rules:System.outorSystem.errprintStackTrace()All such occurrences have been replaced with appropriate
logger.debug()orlogger.error()statements while maintaining existing logging behavior (especially within prettyPrint helpers).Additionally:
@SuppressWarningsannotations.System.outusage for debugging convenience.Fixes: none (code quality cleanup)
Type of Change
Checklist
Screenshots / Additional Context
No visual changes — this is a pure code hygiene and Sonar alignment cleanup.