Get namespace from package-info #2150 #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get namespace from package-info swagger-api#2150 * Revert to single imports * Add unit test coverage
|
@fehguy Thanks for accepting this PR. My team has a defect in our product, and the resolution depends on these changes. Do you have a timeline for when this PR will be released? That would be very helpful to us as we try to plan our work. |
|
Today! |
|
Thanks! We've adopted the new version, and it enabled us to resolve our bug. Should we close #2150 ? |
|
Thanks--it's closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue 2150. When resolving a
JavaTypeto a SwaggerModel, if the type is annotated withXmlRootElementand no namespace is specified, the resolver will look inpackage-infofor an package-level annotation.