Infer bean param type also from getters #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment if you use frameworks like FreeBuilder (https://github.com/google/FreeBuilder) to create POJOs (with builders), you end up with interfaces or abstract classes that only have getters (with builders and concrete classes being automatically generated at compilation time). Previously that would mean that those objects would be ignored by Swagger if used as @BeanParam on jersey resources; this change allows type params and annotations (like @QueryParam) to be picked up from getters.
|
@frantuma - can you review this please? |
|
@gm2211 this seems ok, would you mind adding a test demonstrating the use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if you use frameworks like FreeBuilder (https://github.com/google/FreeBuilder) to create POJOs (with builders), you end up with interfaces or abstract classes that only have getters (with builders and concrete classes being automatically generated at compilation time).
Previously that meant that those objects would be ignored by Swagger if used as @BeanParam on jersey resources; this change allows type params and annotations (like @QueryParam) to be picked up from getters.