Skip to content

Conversation

conorclifford
Copy link
Contributor

Small fix for #1201 (missing deserialisation of ArrayProperty constraints (minItems, maxItems and uniqueItems).

@fehguy
Copy link
Contributor

fehguy commented Apr 23, 2016

@frantuma look OK to you?

@cipresso
Copy link

Hi @fehguy. I have the same issue described in #1201 on both 1.5.8 and 1.5.9. I need the fix committed by @conorclifford as I'm deserializing JSON schema that has minItems and maxItems and embedding the resultant Model.

@cipresso
Copy link

Hi. I tried out the fix and it works. There's an unnecessary import statement "import com.google.common.collect.Maps;" you might want to remove.

@webron
Copy link
Contributor

webron commented Aug 11, 2016

@cipresso thanks for validating it.

@blueskyabove27
Copy link

I understand that this pull request is the first step to resolving the issue of maxItems within definitions of not being read by swagger-parser (swagger-api/swagger-parser#239). Just wanted to mention that this issue is currently causing our internal code generator (which uses swagger-parser/swagger-core) to not handle this case. Whatever could be done to resolve this we would be most grateful for.

@fehguy fehguy merged commit b51406c into swagger-api:master Dec 19, 2016
@fehguy fehguy modified the milestone: v1.5.11 Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants