Add vendor extentions to ObjectProperty and MapProperty. [241] #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, in concept it sounds good but you now have a failing test. Do you want to look at that? |
|
sorry, didn't mean to close |
|
Oh sorry bout that. It was late last night, will take a look later today. |
|
Fixed the tests. |
|
Can you rebase please? |
|
Also, the test doesn't seem to cover the MapProperty. |
…rt are set ignored for jersey2
This references issue 1277 swagger-api#1277. Need this to fix an issue with the use of added in SwaggerSpecFilter caused a NullPointerException when using jackson sub types (https://github.com/swagger-api/swagger-core/blob/master/modules/swagger-core/src/main/java/io/swagger/jackson/ModelResolver.java#L494).
|
Hi @webron, just rebased.
I'm not sure I follow. It looks like it's covering the map property - unless, I'm missing something. If anything, it doesn't seem to be covering the ObjectProperty. I added a test for that, will wait on some clarification on the MapProperty |
webron
added a commit
that referenced
this pull request
Sep 8, 2015
Add vendor extentions to ObjectProperty and MapProperty. [241]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you don't mind, but I came across this issue:
OAI/OpenAPI-Specification#241
I ran into a problem after reading the swagger spec, which seems to suggest the abillity to add a vendor x on a object property.
When using the parser, the vendor-x is blank on a map property.