Fixed #1203: Migrate tests from the Scala to the plain Java #1204
Conversation
iushankin
commented
Jun 26, 2015
iushankin
commented
- Added configuration for the TestNG
- Created sample test
|
|
||
| import java.util.Map; | ||
|
|
||
| public class BeanValidatorTestNG extends Assert { |
There was a problem hiding this comment.
I think just "BeanValidatorTest" is fine... :-)
There was a problem hiding this comment.
Yes, but we have some java tests in scala (i.e. SimpleGenerationTest, ModelPropertyOverrideTest, etc.). And these tests will be run two times (first run by the ScalaTest and second run by the TestNG).
It's best workaround when we have two types of tests.
There was a problem hiding this comment.
ok - we can rename them once the Scala tests have removed... thanks
There was a problem hiding this comment.
I don't like the idea with renaming and TestNG ending. There is nothing wrong if some tests will run twice (of course until they will not fail). This just means that these tests are first candidates for migration.
But my main concern here that we introduce implicit naming convention for Java tests for other community members.
Fixed #1203: Migrate tests from the Scala to the plain Java
|
thank you! |
