Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model converters, build a Scala Model Converter #833

Closed
1 task
fehguy opened this issue Jan 27, 2015 · 1 comment
Closed
1 task

Improve model converters, build a Scala Model Converter #833

fehguy opened this issue Jan 27, 2015 · 1 comment
Assignees
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Jan 27, 2015

It's pretty much impossible to support scala without referring to scala types directly, which means bringing in scala libraries. To keep things lean, it would be best to have a single ScalaModelConverter class, which not only loads the DefaultScalaModule from Jackson, but handles scala types as needed.

  • converter/ScalaEnumTest.scala
@fehguy fehguy added the Feature label Jan 27, 2015
@fehguy fehguy added this to the v1.5.0-M2 milestone Jan 27, 2015
fehguy added a commit that referenced this issue Jan 27, 2015
fehguy added a commit that referenced this issue Jan 27, 2015
@webron webron added the P2 label Mar 10, 2015
@fehguy fehguy self-assigned this Mar 11, 2015
@fehguy
Copy link
Contributor Author

fehguy commented Mar 13, 2015

I've moved scala support into a separate module so it can both evolve independently and not clutter up the java code.

See https://github.com/swagger-api/swagger-scala-module

When this module is included as a dependency, it will automatically be detected and enabled by the ModelConverters.

@fehguy fehguy closed this as completed Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants