Whether an array is required or not should be controlled by `ArraySchema.arraySchema.required` instead of `ArraySchema.schema.required`

[gjgarryuan]

swagger-core/modules/swagger-core/src/main/java/io/swagger/v3/core/jackson/SwaggerAnnotationIntrospector.java

Lines 63 to 65 in 6f6e420

	if (arraySchema.schema().required()) {
	return arraySchema.schema().required();
	}

According to the comments of ArraySchema annotation, ArraySchema.schema defines the model of the items within the array, while ArraySchema.arraySchema defines the model for the model of the array itself.

Hence the code should be changed to use:

if (arraySchema.arraySchema().required()) {
    return arraySchema.arraySchema().required();
}

[frantuma]

can you provide an example of code and expected result?

[gjgarryuan]

For the below DTO class:

public class Person {
    @ArraySchema(
        arraySchema = @Schema(required = true, description = "The person")
    )
    private List<String> addresses;
}

I expect the generated spec to have (but it is not):

{
  "Person": {
    "required": [
      "addresses"
    ]
  }
}

I need to work around this by (note the addition schema attribute to the @ArraySchema annotation):

public class Person {
    @ArraySchema(
        arraySchema = @Schema(description = "The person"),
        schema = @Schema(required = true)
    )
    private List<String> addresses;
}

[frantuma]

Right, thanks for reporting it! Fixed in #3478 (current behaviour left untouched for compatibility, possibly removed in further versions)