Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frozenstep kotlin download file fix #8769

Merged

Conversation

Frozenstep
Copy link
Contributor

PR checklist

  • [x ] Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This updates api.mustache and ApiClient.kt.mustache to handle when the response from the server is a file. It also makes changes in the generated sample code for kotlin-client-petstore

In addition
-We fixed the default headers so they do not override generated headers
-The response Deserializer now looks at the response header content type instead assuming the response is the same as the accept header in the request.
-We added all accept types into the request header

@HugoMario HugoMario merged commit 27bdffb into swagger-api:master Oct 3, 2018
@HugoMario
Copy link
Contributor

thanks a lot @Frozenstep !!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants