Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle when response is a file URL in AlamofireDecodableRequestBuilder. #8700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RedDragonJ
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@ehyche
This is the equivalent change in the AlamofireDecodableRequestBuilder to the change which was made in the non-decodable request in this PR:

#6469

This updates AlamofireImplementations.mustache to handle when the response is an URL. It also makes changes in the generated sample code for:

default configuration (no promisekit or rxswift)
promisekit
rxswift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant